vincbeck commented on code in PR #47136:
URL: https://github.com/apache/airflow/pull/47136#discussion_r1977682029
##########
providers/amazon/src/airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -162,9 +162,9 @@ def is_authorized_dag(
def is_authorized_asset(
self, *, method: ResourceMethod, user: AwsAuthManagerUser, details:
AssetDetails | None = None
) -> bool:
- asset_uri = details.uri if details else None
+ asset_id = details.id if details else None
Review Comment:
Not for this, AWS auth manager is marked as experimental
##########
airflow/auth/managers/models/resource_details.py:
##########
@@ -46,7 +46,7 @@ class DagDetails:
class AssetDetails:
"""Represents the details of an asset."""
- uri: str | None = None
+ id: str | None = None
Review Comment:
Please add a newsfragment but there is no need to support AF2. All auth
managers in main are only compatible with AF3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
