ferruzzi commented on code in PR #43941:
URL: https://github.com/apache/airflow/pull/43941#discussion_r1978366807
##########
airflow/jobs/scheduler_job_runner.py:
##########
@@ -807,8 +818,18 @@ def process_executor_events(
ti.pid,
)
- with Trace.start_span_from_taskinstance(ti=ti) as span:
- cls._set_span_attrs__process_executor_events(span, state, ti)
+ active_ti_span = cls.active_spans.get(ti.key)
+ if active_ti_span is not None:
Review Comment:
Minor nitpick, feel free to ignore and resolve. we can use the walrus
operator to "assign in place" and simplify that a little now, if you want.
```suggestion
if active_ti_span := cls.active_spans.get(ti.key) is not None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
