ferruzzi commented on code in PR #43941:
URL: https://github.com/apache/airflow/pull/43941#discussion_r1978476930
##########
airflow/metrics/validators.py:
##########
@@ -82,7 +82,8 @@ class MetricNameLengthExemptionWarning(Warning):
}
BACK_COMPAT_METRIC_NAMES: set[Pattern[str]] = {re2.compile(name) for name in
BACK_COMPAT_METRIC_NAME_PATTERNS}
-OTEL_NAME_MAX_LENGTH = 63
+# According to otel spec, max length should be 255. Change if the spec gets
revised.
+OTEL_NAME_MAX_LENGTH = 255
Review Comment:
Sorry to be "That Guy", but can you add it back? Arshia's PR stalled out
when folks started focusing on Airflow 3 work so it never got fixed. Whichever
gets merged first wins :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
