pierrejeambrun commented on code in PR #47316:
URL: https://github.com/apache/airflow/pull/47316#discussion_r1979402800
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -278,14 +233,6 @@ def is_authorized_custom_view(self, *, method:
ResourceMethod | str, resource_na
:param user: the user to perform the action on
"""
- @abstractmethod
- def filter_permitted_menu_items(self, menu_items: list[MenuItem]) ->
list[MenuItem]:
Review Comment:
For the front-end, display of menu items or any other permissions related
element, we do not have a solution settled, we imagined a backend endpoint to
retrieve all user permissions, that would be called at the bootstrap of the
front-end app. Then the UI can do some logic and display appropriate elements
based on that.
The backend will still need to verify such permissions too.
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -278,14 +233,6 @@ def is_authorized_custom_view(self, *, method:
ResourceMethod | str, resource_na
:param user: the user to perform the action on
"""
- @abstractmethod
- def filter_permitted_menu_items(self, menu_items: list[MenuItem]) ->
list[MenuItem]:
Review Comment:
For the front-end, display of menu items or any other permissions related
element, we do not have a solution settled, but we imagined a backend endpoint
to retrieve all user permissions, that would be called at the bootstrap of the
front-end app. Then the UI can do some logic and display appropriate elements
based on that.
The backend will still need to verify such permissions too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
