vincbeck commented on code in PR #47316:
URL: https://github.com/apache/airflow/pull/47316#discussion_r1979613141
##########
airflow/auth/managers/base_auth_manager.py:
##########
@@ -278,14 +233,6 @@ def is_authorized_custom_view(self, *, method:
ResourceMethod | str, resource_na
:param user: the user to perform the action on
"""
- @abstractmethod
- def filter_permitted_menu_items(self, menu_items: list[MenuItem]) ->
list[MenuItem]:
Review Comment:
I was thinking something slightly different, very similar to the one I am
deleting. We should a method in auth manager interface that takes a list of
menu items and return the same list but filtered out based on user permissions.
A menu item could be just a string which identifies the menu item such
"variables", "connections" etc ...
On the backend we could expose an API to retrieve all menu items available
to the user and the front-end would use that endpoint to display them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
