amoghrajesh commented on code in PR #47008:
URL: https://github.com/apache/airflow/pull/47008#discussion_r1979682864
##########
.pre-commit-config.yaml:
##########
@@ -694,10 +694,11 @@ repos:
- id: check-base-operator-usage
language: pygrep
name: Check BaseOperatorLink core imports
- description: Make sure BaseOperatorLink is imported from
airflow.models.baseoperatorlink in core
- entry: "from airflow\\.models import.* BaseOperatorLink"
+ description: Make sure BaseOperatorLink is imported from airflow.sdk
in core
+ entry: ".*from airflow\\.sdk\\..* import.* BaseOperatorLink\\b"
Review Comment:
Yeah lets do this for now, but as you mentioned below we should ideally
create a discussion or think about how we do imports in core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
