ashb commented on code in PR #47008:
URL: https://github.com/apache/airflow/pull/47008#discussion_r1983163169
##########
providers/amazon/src/airflow/providers/amazon/aws/links/base_aws.py:
##########
@@ -19,14 +19,20 @@
from typing import TYPE_CHECKING, ClassVar
-from airflow.models import BaseOperatorLink, XCom
+from airflow.models import XCom
from airflow.providers.amazon.aws.utils.suppress import return_on_error
+from airflow.providers.amazon.version_compat import AIRFLOW_V_3_0_PLUS
if TYPE_CHECKING:
from airflow.models import BaseOperator
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.utils.context import Context
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/databricks/src/airflow/providers/databricks/operators/databricks.py:
##########
@@ -41,12 +41,18 @@
)
from airflow.providers.databricks.triggers.databricks import
DatabricksExecutionTrigger
from airflow.providers.databricks.utils.databricks import
normalise_json_content, validate_trigger_event
+from airflow.providers.databricks.version_compat import AIRFLOW_V_3_0_PLUS
if TYPE_CHECKING:
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.utils.context import Context
from airflow.utils.task_group import TaskGroup
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/data_factory.py:
##########
@@ -39,6 +39,13 @@
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.utils.context import Context
+from airflow.providers.microsoft.azure.version_compat import AIRFLOW_V_3_0_PLUS
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py:
##########
@@ -61,6 +61,11 @@
# TODO: Remove once provider drops support for Airflow 2
from airflow.utils.context import Context
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/standard/src/airflow/providers/standard/sensors/external_task.py:
##########
@@ -50,6 +49,12 @@
from airflow.utils.context import Context
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/google/src/airflow/providers/google/cloud/links/datafusion.py:
##########
@@ -21,14 +21,19 @@
from typing import TYPE_CHECKING, ClassVar
-from airflow.models import BaseOperatorLink, XCom
+from airflow.models import XCom
+from airflow.providers.google.version_compat import AIRFLOW_V_3_0_PLUS
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/google/src/airflow/providers/google/cloud/links/base.py:
##########
@@ -19,12 +19,17 @@
from typing import TYPE_CHECKING, ClassVar
-from airflow.models import BaseOperatorLink, XCom
+from airflow.models import XCom
+from airflow.providers.google.version_compat import AIRFLOW_V_3_0_PLUS
if TYPE_CHECKING:
from airflow.models import BaseOperator
from airflow.models.taskinstancekey import TaskInstanceKey
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/google/src/airflow/providers/google/cloud/operators/dataproc_metastore.py:
##########
@@ -40,9 +40,17 @@
if TYPE_CHECKING:
from google.protobuf.field_mask_pb2 import FieldMask
+ from airflow.models import BaseOperator
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.utils.context import Context
+from airflow.providers.google.version_compat import AIRFLOW_V_3_0_PLUS
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/google/src/airflow/providers/google/marketing_platform/links/analytics_admin.py:
##########
@@ -18,12 +18,19 @@
from typing import TYPE_CHECKING, ClassVar
-from airflow.models import BaseOperator, BaseOperatorLink, XCom
+from airflow.models import BaseOperator, XCom
if TYPE_CHECKING:
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.utils.context import Context
+from airflow.providers.google.version_compat import AIRFLOW_V_3_0_PLUS
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/yandex/src/airflow/providers/yandex/links/yq.py:
##########
@@ -30,6 +30,13 @@
# TODO: Remove once provider drops support for Airflow 2
from airflow.utils.context import Context
+from airflow.providers.common.compat.version_compat import AIRFLOW_V_3_0_PLUS
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/google/src/airflow/providers/google/cloud/links/dataproc.py:
##########
@@ -25,14 +25,20 @@
import attr
from airflow.exceptions import AirflowProviderDeprecationWarning
-from airflow.models import BaseOperatorLink, XCom
+from airflow.models import XCom
from airflow.providers.google.cloud.links.base import BASE_LINK, BaseGoogleLink
+from airflow.providers.google.version_compat import AIRFLOW_V_3_0_PLUS
if TYPE_CHECKING:
from airflow.models import BaseOperator
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.utils.context import Context
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/dbt/cloud/src/airflow/providers/dbt/cloud/operators/dbt.py:
##########
@@ -38,6 +39,11 @@
from airflow.providers.openlineage.extractors import OperatorLineage
from airflow.utils.context import Context
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/synapse.py:
##########
@@ -38,6 +38,13 @@
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.utils.context import Context
+from airflow.providers.microsoft.azure.version_compat import AIRFLOW_V_3_0_PLUS
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/databricks/src/airflow/providers/databricks/plugins/databricks_workflow.py:
##########
@@ -48,8 +48,14 @@
if TYPE_CHECKING:
from sqlalchemy.orm.session import Session
+ from airflow.models import BaseOperator
from airflow.providers.databricks.operators.databricks import
DatabricksTaskBaseOperator
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
##########
providers/microsoft/azure/src/airflow/providers/microsoft/azure/operators/powerbi.py:
##########
@@ -31,6 +31,13 @@
from airflow.models.taskinstancekey import TaskInstanceKey
from airflow.utils.context import Context
+from airflow.providers.microsoft.azure.version_compat import AIRFLOW_V_3_0_PLUS
+
+if AIRFLOW_V_3_0_PLUS:
+ from airflow.sdk.definitions.baseoperatorlink import BaseOperatorLink
Review Comment:
```suggestion
from airflow.sdk import BaseOperatorLink
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
