ferruzzi commented on code in PR #43941:
URL: https://github.com/apache/airflow/pull/43941#discussion_r1980663897
##########
tests/jobs/test_scheduler_job.py:
##########
@@ -2367,6 +2370,194 @@ def
test_runs_are_created_after_max_active_runs_was_reached(self, dag_maker, ses
dag_runs = DagRun.find(dag_id=dag.dag_id, session=session)
assert len(dag_runs) == 2
+ @pytest.mark.parametrize(
+ "ti_state, final_ti_span_status",
+ [(State.SUCCESS, SpanStatus.ENDED), (State.RUNNING,
SpanStatus.ACTIVE)],
+ )
Review Comment:
pytest.param lets us give pretty names to parameterized tests, the `id` will
get appended to the test name for easier debugging if one fails.
```suggestion
@pytest.mark.parametrize(
"ti_state, final_ti_span_status",
[
pytest,param(State.SUCCESS, SpanStatus.ENDED,
id="ended_successfully"),
pytest.param(State.RUNNING, SpanStatus.ACTIVE, id="still_active")
],
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
