Lee-W commented on code in PR #47381:
URL: https://github.com/apache/airflow/pull/47381#discussion_r1981540409
##########
task_sdk/src/airflow/sdk/definitions/asset/__init__.py:
##########
@@ -451,11 +451,16 @@ def iter_dag_dependencies(self, *, source: str, target:
str) -> Iterator[DagDepe
:meta private:
"""
+ from airflow.models.asset import retrieve_asset_ids
+ from airflow.utils.session import create_session
+
+ with create_session() as session:
+ asset_id = str(retrieve_asset_ids(assets=[self],
session=session)[0])
yield DagDependency(
source=source or "asset",
target=target or "asset",
dependency_type="asset",
- dependency_id=self.name,
+ dependency_id=asset_id,
Review Comment:
How label should be set?
* dag -> `dag_display_name` or `dag_id`
* asset -> "uri: {asset.name}, name: {asset.name}"
* asset alias -> asset_alias.name
* asset ref -> "{asset_ref.name}" or "{asset_ref.uri" (if cannot be resolved
to anything) -> "uri: {asset.name}, name: {asset.name}" (if it can be resolved
to asset)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
