insomnes commented on code in PR #47407:
URL: https://github.com/apache/airflow/pull/47407#discussion_r1984675831


##########
task_sdk/src/airflow/sdk/execution_time/task_runner.py:
##########
@@ -292,7 +292,7 @@ def xcom_pull(
 
         if task_ids is None:
             # default to the current task if not provided
-            task_ids = self.task_id
+            task_ids = [self.task_id]

Review Comment:
   I believe the case of `task_instance` pulling its xcom is rare. And it was 
also easy to miss during the multiple task ids feature PR.
   
   But yeah, test coverage was not ideal. And I've detected this only from 
expanding tests to this function in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to