amoghrajesh commented on code in PR #47407:
URL: https://github.com/apache/airflow/pull/47407#discussion_r1986060116
##########
task_sdk/tests/execution_time/test_task_runner.py:
##########
@@ -1153,10 +1160,12 @@ def execute(self, context):
run(runtime_ti, log=mock.MagicMock())
- if isinstance(task_ids, str):
+ if not isinstance(task_ids, Iterable) or isinstance(task_ids, str):
task_ids = [task_ids]
for task_id in task_ids:
+ if task_id is None or isinstance(task_id, ArgNotSet):
+ task_id = runtime_ti.task_id
Review Comment:
You have made the change I requested you to :)
I was asking for:
task_id = runtime_ti.task_id => `task_id = test_task_id`
##########
task_sdk/tests/execution_time/test_task_runner.py:
##########
@@ -1153,10 +1160,12 @@ def execute(self, context):
run(runtime_ti, log=mock.MagicMock())
- if isinstance(task_ids, str):
+ if not isinstance(task_ids, Iterable) or isinstance(task_ids, str):
task_ids = [task_ids]
for task_id in task_ids:
+ if task_id is None or isinstance(task_id, ArgNotSet):
+ task_id = runtime_ti.task_id
Review Comment:
You have made the change I requested you to :)
I was asking for:
`task_id = runtime_ti.task_id` => `task_id = test_task_id`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
