MaksYermak commented on code in PR #47056: URL: https://github.com/apache/airflow/pull/47056#discussion_r1986898868
########## providers/apache/kafka/src/airflow/providers/apache/kafka/hooks/base.py: ########## @@ -22,6 +22,7 @@ from confluent_kafka.admin import AdminClient from airflow.hooks.base import BaseHook +from airflow.providers.google.cloud.hooks.managed_kafka import ManagedKafkaHook Review Comment: @eladkal @potiuk I am ready to prepare a fix ASAP. But I have a question. In case when we can't use a google Hook inside Kafka provider what is a better way to use code from the google provider? Could I make a conditional import here as a solution? The reason for using Google Hook was that for the Kafka cluster managed by Google for establishing connection we need to pass a function which generates a token for Confluent with google's credentials. And a function which gets a google's credential exists only inside the Google provider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
