uranusjr commented on code in PR #47381:
URL: https://github.com/apache/airflow/pull/47381#discussion_r1986671297
##########
airflow/serialization/serialized_objects.py:
##########
@@ -1103,22 +1106,26 @@ def detect_task_dependencies(task: Operator) ->
list[DagDependency]:
DagDependency(
source=task.partial_kwargs["external_dag_id"],
target=task.dag_id,
+ label=task.task_display_name or task.task_id,
dependency_type="sensor",
dependency_id=task.task_id,
)
)
+
for obj in task.outlets or []:
if isinstance(obj, Asset):
deps.append(
DagDependency(
source=task.dag_id,
target="asset",
+ label=obj.name,
dependency_type="asset",
- dependency_id=obj.name,
+ dependency_id=None,
Review Comment:
Why don’t we give this a dependency id? We probably should since otherwise
all asset and alias dependencies would have the same `node_id`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
