hussein-awala commented on code in PR #47406:
URL: https://github.com/apache/airflow/pull/47406#discussion_r1989989415
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/pod_generator.py:
##########
@@ -504,7 +504,7 @@ def deserialize_model_file(path: str) -> k8s.V1Pod:
pod = yaml.safe_load(stream)
else:
pod = None
- log.warning("Model file %s does not exist", path)
+ log.warning("Model file %s does not exist or is not defined. Using
default model file.", path)
Review Comment:
IMHO this will be better:
```python
@staticmethod
def deserialize_model_file(path: str | None) -> k8s.V1Pod:
"""
Generate a Pod from a file.
:param path: Path to the file
:return: a kubernetes.client.models.V1Pod
"""
if not path:
pod = None
log.warning("Model file is not defined. Using default model
file.")
elif os.path.exists(path):
with open(path) as stream:
pod = yaml.safe_load(stream)
else:
pod = None
log.warning("Model file %s does not exist", path)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
