github-advanced-security[bot] commented on code in PR #47406:
URL: https://github.com/apache/airflow/pull/47406#discussion_r1990048441
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/pod_generator.py:
##########
@@ -492,19 +492,22 @@
return api_client.sanitize_for_serialization(pod)
@staticmethod
- def deserialize_model_file(path: str) -> k8s.V1Pod:
+ def deserialize_model_file(path: str | None) -> k8s.V1Pod:
"""
Generate a Pod from a file.
:param path: Path to the file
:return: a kubernetes.client.models.V1Pod
"""
- if os.path.exists(path):
+ if not path:
+ pod = None
+ log.warning("Model file is not defined. Using default model file.")
+ elif os.path.exists(path):
with open(path) as stream:
pod = yaml.safe_load(stream)
else:
pod = None
- log.warning("Model file %s does not exist", path)
+ log.warning("Model file %s does not exist.", path)
Review Comment:
## Clear-text logging of sensitive information
This expression logs [sensitive data (secret)](1) as clear text.
This expression logs [sensitive data (secret)](2) as clear text.
[Show more
details](https://github.com/apache/airflow/security/code-scanning/392)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
