vincbeck commented on code in PR #47759:
URL: https://github.com/apache/airflow/pull/47759#discussion_r1995515675
##########
providers/amazon/tests/system/amazon/aws/example_mwaa.py:
##########
@@ -77,12 +85,32 @@
)
# [END howto_sensor_mwaa_dag_run]
+ @task
Review Comment:
I am not against but this feels weird to me. System tests are DAGs and
having a task that looks like a unit test feels really odd. I know you had a
conversation in the other PR and again, I am not against. I just wanted to call
it out. At least, if we go with that, I'd add comments to explain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
