o-nikolas commented on code in PR #47759:
URL: https://github.com/apache/airflow/pull/47759#discussion_r1996104898
##########
providers/amazon/tests/system/amazon/aws/example_mwaa.py:
##########
@@ -77,12 +85,32 @@
)
# [END howto_sensor_mwaa_dag_run]
+ @task
Review Comment:
Yeah, I hear this, it is very integration test-ish, if not unit. The reason
it has to be a system level test is that it is explicitly testing the response
form the API (where a log message is being parsed, So if the format of that
ever changes the code needs updating). So I think this unfortunately has to
stay here.
In the end I think it's a pretty tidy piece of test code, so not too bad.
But I do agree that a comment explaining this context is needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
