PNL0 commented on code in PR #47557:
URL: https://github.com/apache/airflow/pull/47557#discussion_r2007495901
##########
airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -246,6 +247,23 @@ def patch_dag(
data = patch_body.model_dump(include=fields_to_update, by_alias=True)
+ is_paused = data.get("is_paused")
+
+ active_dag_runs = session.scalars(
+ select(DagRun).filter(
+ DagRun.dag_id == dag_id, DagRun.state.in_([DagRunState.RUNNING,
DagRunState.QUEUED])
+ )
+ ).all()
+
+ for dag_run in active_dag_runs:
+ if is_paused:
+ dag_run.set_state(DagRunState.QUEUED)
Review Comment:
> I disagree with this. Why will a dag run go from running to queued state?
I think that if a DAG is paused, then the dag run shouldn't continue to run
(which implies a change in its state from running to other state that keeps the
dag run paused).
I chose queued state, because a similar behavior already happens in Airflow,
when you trigger a paused dag (dag run state goes to queued).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
