PNL0 commented on code in PR #47557:
URL: https://github.com/apache/airflow/pull/47557#discussion_r2008091106
##########
airflow/api_fastapi/core_api/routes/public/dags.py:
##########
@@ -246,6 +247,23 @@ def patch_dag(
data = patch_body.model_dump(include=fields_to_update, by_alias=True)
+ is_paused = data.get("is_paused")
+
+ active_dag_runs = session.scalars(
+ select(DagRun).filter(
+ DagRun.dag_id == dag_id, DagRun.state.in_([DagRunState.RUNNING,
DagRunState.QUEUED])
+ )
+ ).all()
+
+ for dag_run in active_dag_runs:
+ if is_paused:
+ dag_run.set_state(DagRunState.QUEUED)
Review Comment:
> What about if you pause a running DAG? Maybe you can check the behaviour
in Airflow 2 UI
If you pause a running dag, then the dag run state will be stuck on running
and as result the duration keeps on increasing permanently, which it's not the
desired behavior for pause functionality.
This behavior happens in Airflow 2 and 3 UIs (also if I'm not mistaken, the
issue was reported, when airflow 3 UI wasn't released).
That's why I think the dag run state can't stay on running when the DAG is
paused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
