kailaa-sri commented on PR #48114:
URL: https://github.com/apache/airflow/pull/48114#issuecomment-2750043225

   @amoghrajesh  As mentioned in this Issue #40567
   
   I tested this by removing  PT007 from the ignore list and fixing the ruff 
errors list.
   
   
https://github.com/apache/airflow/blob/a1808ac7b14811194094cd1762a171fe1d8aa14b/pyproject.toml#L226
 
   
   **Error**
   ```
   task-sdk\tests\task_sdk\execution_time\test_task_runner.py:1326:9: PT007 
Wrong values type in `@pytest.mark.parametrize` expected `list` of `tuple`
        |
   1324 |       @pytest.mark.parametrize(
   1325 |           ("logical_date", "check"),
   1326 |           (
        |  _________^
   1327 | |             pytest.param(None, pytest.raises(KeyError), 
id="no-logical-date"),     
   1328 | |             pytest.param(timezone.datetime(2024, 12, 3), 
contextlib.nullcontext(), id="with-logical-date"),
   1329 | |         ),
        | |_________^ PT007
   ```
   
   I still see similar tuple as top level in other folders. I thought I would 
fix this as folderlevel batch and enable PT007 docstyle. 
   
   Please confirm PT007 docstyle is not required for this folder ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to