o-nikolas commented on PR #48513: URL: https://github.com/apache/airflow/pull/48513#issuecomment-2770825768
Follow up on this: > > Overall looks good! Good job with figuring out all these things. Two questions: > > ``` > > * Can we add unit tests? ECS executor changes are not tested > > ``` > > Sure, I can look at adding some. But most all of the actual behaviour of the executor itself hasn't changed. Just the interface to it (which should honestly be tested by the base executor once all this stuff moves into that class). But I'll look at adding a few. Unit test added! It pretty comprehensively tests the task SDK path beginning to end. Let me know what you think! > > > ``` > > * It looks like it is but just double checking. With these changes, is ECS executor still compatible with AF2? > > ``` > > Yupp it should be still working with AF2, I can do a manual test to verify 👍 Manually setup a repro with AF2 and the current executor, everything works as expected! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
