o-nikolas commented on code in PR #48699:
URL: https://github.com/apache/airflow/pull/48699#discussion_r2027900487
##########
devel-common/src/tests_common/pytest_plugin.py:
##########
@@ -224,6 +224,12 @@ def pytest_addoption(parser: pytest.Parser):
dest="db_init",
help="Forces database initialization before tests",
)
+ group.addoption(
+ "--without-db-init",
+ action="store_true",
+ dest="no_db_init",
+ help="Forces NO database initialization before tests",
Review Comment:
Yeah, there is a very confusing venn diagram here of possible paths. Really
with should be called "force-db-init" since it only forces it to happen, it can
happen when that thing is set to false (which you would think means force do
not, but no, it's only force in the true case). And so mine is the opposite,
covering that case. It forces no db-init in the pytest plugin (not even
evaluating other paths that could lead to inits).
I know it's confusing, hopefully that makes sense!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
