vincbeck commented on code in PR #48699:
URL: https://github.com/apache/airflow/pull/48699#discussion_r2027677647
##########
dev/breeze/src/airflow_breeze/utils/run_tests.py:
##########
@@ -396,6 +396,9 @@ def generate_args_for_pytest(
args.append(f"--ignore={group_folder}")
if test_group not in IGNORE_DB_INIT_FOR_TEST_GROUPS:
args.append("--with-db-init")
+ if test_group == GroupOfTests.SYSTEM:
+ # System tests will be inited with the api server is started
Review Comment:
```suggestion
# System tests will be inited with the api server started
```
##########
devel-common/src/tests_common/pytest_plugin.py:
##########
@@ -224,6 +224,12 @@ def pytest_addoption(parser: pytest.Parser):
dest="db_init",
help="Forces database initialization before tests",
)
+ group.addoption(
+ "--without-db-init",
+ action="store_true",
+ dest="no_db_init",
+ help="Forces NO database initialization before tests",
Review Comment:
This feels redundant with `--with-db-init`. If `--with-db-init` is not set
then no DB initialization should happen. Why do we need this flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
