amarlearning commented on PR #48791: URL: https://github.com/apache/airflow/pull/48791#issuecomment-2779409446
> I think masking a password/other sensitive field should be done on structured data _regardless_ of the length, it's only the "mask when the value appears elsewhere in a string" that should depend on the list. > > Maybe this is what happens, but I don't think the tests check that behaviour You're right. Structured data fields like passwords and tokens are always masked via `_redact`, regardless of length. For unstructured text, only values exceeding the minimum length are masked in `add_mask`. I can add more tests to verify this behavior thoroughly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
