jscheffl commented on code in PR #48223:
URL: https://github.com/apache/airflow/pull/48223#discussion_r2021739617
##########
providers/common/sql/pyproject.toml:
##########
@@ -86,6 +86,10 @@ dev = [
"apache-airflow-devel-common",
"apache-airflow-providers-openlineage",
# Additional devel dependencies (do not remove this line and add extra
development dependencies)
+ "apache-airflow-providers-common-sql[pandas]",
Review Comment:
I am thinking a bit about this dependency. Is this no generating a cyclic
dependency? I'd assume the base "sql" backage makes generics and interfaces,
why does it have fr dev a dependency to all concrete implementations? Pytests
should be in the concrete packages each having a dependency to the common?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
