potiuk commented on code in PR #48914:
URL: https://github.com/apache/airflow/pull/48914#discussion_r2041167489
##########
airflow-ctl/src/airflowctl/api/datamodels/generated.py:
##########
@@ -136,7 +129,7 @@ class BulkDeleteActionConnectionBody(BaseModel):
entities: Annotated[
list[str], Field(description="A list of entity id/key to be deleted.",
title="Entities")
]
- action_on_non_existence: BulkActionNotOnExistence | None = "fail"
+ action_on_non_existence: BulkActionNotOnExistence | None =
BulkActionNotOnExistence.FAIL
Review Comment:
Why? Such modificatiosn of generated code are very, very prone to future
errors - codegen generation might change any time and someone will have to dig
it out and find out how to modify the resuling code to fix the issue - and
since that will happen randomly and usually will break someone's PR, that might
be super confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
