bugraoz93 commented on code in PR #48914:
URL: https://github.com/apache/airflow/pull/48914#discussion_r2037217728
##########
airflow-ctl/src/airflowctl/api/datamodels/generated.py:
##########
@@ -136,7 +129,7 @@ class BulkDeleteActionConnectionBody(BaseModel):
entities: Annotated[
list[str], Field(description="A list of entity id/key to be deleted.",
title="Entities")
]
- action_on_non_existence: BulkActionNotOnExistence | None = "fail"
+ action_on_non_existence: BulkActionNotOnExistence | None =
BulkActionNotOnExistence.FAIL
Review Comment:
Seems like it. I think we can exclude it for now since it is not a thing we
are implementing and can find a automated way as a next step
##########
.pre-commit-config.yaml:
##########
@@ -1345,6 +1345,13 @@ repos:
pass_filenames: false
files: ^airflow-core/src/airflow/api_fastapi/execution_api/.*\.py$
require_serial: true
+ - id: generate-airflowctl-datamodels
+ name: Generate Datamodels for AirflowCTL
+ language: python
+ entry: uv run -p 3.12 --no-dev --no-progress --active --group codegen
--project apache-airflow-ctl --directory airflow-ctl/ datamodel-codegen
+ pass_filenames: false
+ files: ^airflow-core/src/airflow/api_fastapi/execution_api/.*\.py$
Review Comment:
```suggestion
files: ^airflow-core/src/airflow/api_fastapi/core_api/.*\.py$
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
