cjbj commented on code in PR #49533:
URL: https://github.com/apache/airflow/pull/49533#discussion_r2053257182
##########
providers/oracle/tests/unit/oracle/hooks/test_oracle.py:
##########
@@ -295,7 +295,7 @@ def test_type_checking_thick_mode_config_dir(self):
"schema": None,
"port": 1521,
},
-
"oracle://login:password@host:1521/(DESCRIPTION=(ADDRESS=(host=oracle://somedb.example.com)(protocol=TCP)(port=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb)))",
+
"oracle+oracledb://login:password@host:1521?service_name=(DESCRIPTION=(ADDRESS=(host=oracle://somedb.example.com)(protocol=TCP)(port=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb)))",
Review Comment:
This syntax won't work in SQLAlchemy. The following does work:
```
oracle+oracledb://login:password@(DESCRIPTION=(ADDRESS=(host=localhost)(protocol=TCP)(port=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb)))
```
(You can see why I generally prefer the [Connect Args
approach](https://docs.sqlalchemy.org/en/20/dialects/oracle.html#connecting-with-easy-connect-strings)
when manually connecting since it removes all the pain of mixing Oracle
connection string syntax with SQLAlchemy engine syntax.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
