guan404ming commented on code in PR #49533:
URL: https://github.com/apache/airflow/pull/49533#discussion_r2053277728
##########
providers/oracle/tests/unit/oracle/hooks/test_oracle.py:
##########
@@ -295,7 +295,7 @@ def test_type_checking_thick_mode_config_dir(self):
"schema": None,
"port": 1521,
},
-
"oracle://login:password@host:1521/(DESCRIPTION=(ADDRESS=(host=oracle://somedb.example.com)(protocol=TCP)(port=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb)))",
+
"oracle+oracledb://login:password@host:1521?service_name=(DESCRIPTION=(ADDRESS=(host=oracle://somedb.example.com)(protocol=TCP)(port=1521))(CONNECT_DATA=(SERVICE_NAME=orclpdb)))",
Review Comment:
Sure, let me remove the invalid test case here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
