vincbeck commented on code in PR #49664: URL: https://github.com/apache/airflow/pull/49664#discussion_r2058565193
########## providers/common/compat/src/airflow/providers/common/compat/security/permissions.py: ########## Review Comment: To be honest I dont remember if this is used in older version of providers :/ When when I looked at #47553, this PR adds `RESOURCE_DAG_VERSION` in compat provider and is not used anywhere. So it might be something we added for nothing. Ideally FAB permissions should only be used in FAB. We can always remove it and if some providers are using them they can use older version of compat provider? ########## providers/common/compat/src/airflow/providers/common/compat/security/permissions.py: ########## Review Comment: To be honest I dont remember if this is used in older version of providers :/ When I look at #47553, this PR adds `RESOURCE_DAG_VERSION` in compat provider and is not used anywhere. So it might be something we added for nothing. Ideally FAB permissions should only be used in FAB. We can always remove it and if some providers are using them they can use older version of compat provider? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
