potiuk commented on code in PR #49664: URL: https://github.com/apache/airflow/pull/49664#discussion_r2059920219
########## providers/common/compat/src/airflow/providers/common/compat/security/permissions.py: ########## Review Comment: As @ashb commented -> we should not remove stuff from compat until it is needed. That's generally the purpose of common.compat. Generally (see slack discussion) https://apache-airflow.slack.com/archives/C06K9Q5G2UA/p1745534416301429 - we should not remove anything from common.compat - until we get them to "end-of-life". Common.compat contains code that supports old provider versions (like FAB) that we cannot upgrade together with other providers - and as long as we want to still release providers that are `Airflow 2` compatible we need to keep the compatibility code as it was and `common.compat` should not have stuff removed (basically common.compat should be `1.+`. That also include test code in common.compat (currently still removed). If we need to remove stuff from `common-core` that will make the test break - we should move it to `common.compat`. The `common.compat` is shared - which means that for Airflow 2 the same version of compat is used by new providers released now and old providers (like fab1.*) that are needed to be installed in Airfllow 2 - which basically means that until we support new providers to work on Airflow 2, common compat should keep version 1 and not remove code. This will change when we stop supporting providers for Airflow 2 (12 months from now). Then we will be able to bump `common.compat` to 2.* and remove all the stuff that was only needed for Airflow 2 -only providers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
