ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production Docker image support including refactoring of build scripts - depends on [AIRFLOW-5704] URL: https://github.com/apache/airflow/pull/6266#discussion_r336896656
########## File path: BREEZE.rst ########## @@ -912,32 +914,26 @@ Docker images used by Breeze For all development tasks related integration tests and static code checks we are using Docker images that are maintained in DockerHub under ``apache/airflow`` repository. -There are three images that we currently manage: +There are those images that we currently manage (all of them are stages in multi-staging +`<Dockerfile>`_ dockerfile.: -* **Slim CI** image that is used for static code checks (size around 500MB) - tag follows the pattern - of ``<BRANCH>-python<PYTHON_VERSION>-ci-slim`` (for example ``apache/airflow:master-python3.6-ci-slim``). - The image is built using the `<Dockerfile>`_ dockerfile. -* **Full CI image*** that is used for testing - containing a lot more test-related installed software +* ** CI image*** that is used for testing - containing a lot more test-related installed software (size around 1GB) - tag follows the pattern of ``<BRANCH>-python<PYTHON_VERSION>-ci`` - (for example ``apache/airflow:master-python3.6-ci``). The image is built using the - `<Dockerfile>`_ dockerfile. + (for example ``apache/airflow:master-python3.6-ci``). It is also used to run some of the + static checks (pylint, mypy, flake8, as well as to generate the documentation) +* ** PROD image*** that is a base for Production-ready image of Apache Airflow. + (size around 1GB) - tag follows the pattern of ``<BRANCH>-python<PYTHON_VERSION>`` + (for example ``apache/airflow:master-python3.6``). Review comment: We shouldn't imply that `apache/airflow:master-python3.6` is a suitable prod image which this bullet point does to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services