ashb commented on a change in pull request #6266: [AIRFLOW-2439] Production 
Docker image support including refactoring of build scripts - depends on 
[AIRFLOW-5704]
URL: https://github.com/apache/airflow/pull/6266#discussion_r336909165
 
 

 ##########
 File path: scripts/ci/ci_flake8.sh
 ##########
 @@ -22,16 +22,21 @@ MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 
 export AIRFLOW_CI_SILENT=${AIRFLOW_CI_SILENT:="true"}
 
-export PYTHON_VERSION=3.5
 
 Review comment:
   I'm not sure about this. If I'm following the code right removing this will 
autodetect the python version to use based on the host python. But we 
_explicitly_ want to run these tests agsinst 3.5 locally. If I have python 3.7 
locally it would attempt to use that version which isn't what we want.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to