bbovenzi commented on code in PR #47849:
URL: https://github.com/apache/airflow/pull/47849#discussion_r2063867419
##########
airflow-core/src/airflow/ui/src/utils/query.ts:
##########
@@ -20,6 +20,11 @@ import { useDagServiceGetDagDetails } from "openapi/queries";
import type { TaskInstanceState } from "openapi/requests/types.gen";
import { useConfig } from "src/queries/useConfig";
+export const getOrderBy = (pre_defined?: string): string[] => {
+ const sortParam = new
URLSearchParams(globalThis.location.search).getAll("sort");
+ return (sortParam.length === 0 && pre_defined != undefined) ? [pre_defined]
: sortParam;
+};
+
Review Comment:
```suggestion
export const getOrderBy = (defaultOrder?: string): string[] => {
const sortParam = new
URLSearchParams(globalThis.location.search).getAll("sort");
return (sortParam.length === 0 && defaultOrder !== undefined) ?
[defaultOrder] : sortParam;
};
```
We generally don't want to use snake_case in our typescript code. The only
ones we do have are generated from the python API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
