mariana-marcal-santana commented on code in PR #47849:
URL: https://github.com/apache/airflow/pull/47849#discussion_r2067488465
##########
airflow-core/src/airflow/ui/src/utils/query.ts:
##########
@@ -20,6 +20,11 @@ import { useDagServiceGetDagDetails } from "openapi/queries";
import type { TaskInstanceState } from "openapi/requests/types.gen";
import { useConfig } from "src/queries/useConfig";
+export const getOrderBy = (pre_defined?: string): string[] => {
+ const sortParam = new
URLSearchParams(globalThis.location.search).getAll("sort");
+ return (sortParam.length === 0 && pre_defined != undefined) ? [pre_defined]
: sortParam;
+};
+
Review Comment:
Hello @bbovenzi !
In my last commit I fixed the casing, ran the afore mentioned commands and
fixed the things marked in the lint command (that were from my commits).
Anything else I should change?
Also, I noticed that the code failed these tests:
https://github.com/apache/airflow/actions/runs/14682302749/job/41221555783. How
should I fix it?
I noticed that it fails where I changed orderBy?: string to orderBy?:
string[]. From what I saw, I think it's because it clashes with the definition
on the file
airflow-core/src/airflow/api_fastapi/core_api/openapi/v1-rest-api-generated.yaml
(that I changed but I believe it got overwritten).
Could you confirm this please?
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
