potiuk commented on code in PR #49938: URL: https://github.com/apache/airflow/pull/49938#discussion_r2069008941
########## providers/common/messaging/src/airflow/providers/common/messaging/providers/kafka.py: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Hmm. I have some doubts.. I already had it already but this one actually makes it more visible. Why are we adding the `common.messaging` implementation to common.messaging? They shoud be in "Amazon" (sqs) and `Kafka` provider (kafka`) - NOT in common.messaging I think. Similarly to common.sql - where implementation of teh DBAPIHook is in the respective provider. OR am I wrong ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
