potiuk commented on code in PR #49938: URL: https://github.com/apache/airflow/pull/49938#discussion_r2069050039
########## providers/common/messaging/src/airflow/providers/common/messaging/providers/kafka.py: ########## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: My proposal would be to implement similar feature as we have in DBAPI Hook where we have provider's manager and exposing "Hooks" available in provider - just expose "MessageQueue" implementations - that would be very similar code and it would work in a similar way => we have all the discovery code already in place. The added benefit is that we could also automatically show it as output of `airflow providers` CLI, and also our documentation here https://airflow.apache.org/docs/apache-airflow-providers/core-extensions/index.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
