bugraoz93 commented on PR #49601: URL: https://github.com/apache/airflow/pull/49601#issuecomment-2844220135
> @bugraoz93 I wanted to limit this PR to only transitions the `get-value` config command, as this might get too large and hard to review if all 4 commands (get-value, list, lint, update) are implemented. Unit tests are added, please take a look and let me know your thoughts. > > I have one concern here, in the old airflow CLI, `get` is not displayed as a command (see below). > <img width="855" alt="image" src="https://github.com/user-attachments/assets/0f8f5607-6fe2-4b5d-a435-2e0b2d6833f9"; /> > > However, with the new auto-gen of commands, `get` will be listed as one of the available commands when I use `airflowctl config -h`. I am not sure is this is intended, or we should find a way to undo that. > <img width="433" alt="image" src="https://github.com/user-attachments/assets/7d87eb8a-fb19-422e-be4c-683249d7e68a"; /> > > note: trying to fix CI error! Hey @yunchipang, it is okay to do it step by step and command by com and. For `get-value`, as I mentioned in my previous comment. >Basic commands are already generated automatically via 1-1 operation-command mapping. Operations https://github.com/apache/airflow/blob/main/airflow-ctl/src/airflowctl/api/operations.py Auto Generation https://github.com/apache/airflow/blob/879b6810ba496d7471761a3b6e5b2c5b953b358e/airflow-ctl/src/airflowctl/ctl/cli_config.py#L212 If you run airflowctl --help or more specifically airflowctl config --help. For example, in this case, all methods you added should stay and get-value shouldn't be there because `get` comes from the generated part. This is expected, and we shouldn't implement anything that comes from generated commands from operations. This is not a problem but intended behavior. They will serve to the same purpose and do the same thing. So please skip get-value. Only focus on the capability other than generated ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
