bugraoz93 commented on PR #49601: URL: https://github.com/apache/airflow/pull/49601#issuecomment-2848787579
> @bugraoz93 Thanks so much for the clarification! Just making sure I fully understand — since `get` is already handled by auto-gen, I should only focus on implementing `list`, `lint` and `update`, correct? > > Also, when running `airflowctl config -h`, I should expect to see four commands: `get`, `list`, `lint`, and `update`, meaning `get-value` will no longer appear as an option. > > Please let me know if I’ve misunderstood anything! @yunchipang Yes, you should focus on `list`, `lint` and `update`. It is okay to have some duplicate code, we are expecting a bit of code duplication with `Airflow CLI config command` in ([airflow-core/src/airflow/cli/commands/config_command.py](https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/cli/commands/config_command.py)) at the beginning until we deprecate and move the same behaviours from `Airflow CLI`. At the end of all transitions, you should expect to see `get`, `list`, `lint`, and `update` at the end of `airflowctl config -h`. We don't necessarily need to follow the same command naming as `Airflow CLI`, it is already a new tool, the important thing is consistency between all commands. For example `get command` exists in `airflowctl connections`, `airflowctl pools` or `airflowctl variables`, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
