kacpermuda opened a new pull request, #50392:
URL: https://github.com/apache/airflow/pull/50392
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR adds OpenLineage support for `DatabricksSqlHook` and therefore
`DatabricksSqlOperator`. It also introduces caching the hook on the operator
level and gathering Databricks query_ids in the Hook when executing queries.
The OpenLineage logic implemented in `DatabricksSqlHook` is very similar to
all other database Hooks already supported, and implementing a common interface
from `DbApiHook`:
- Snowflake implementation
[url](https://github.com/apache/airflow/blob/main/providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake.py#L562).
- Redshift implementation
[url](https://github.com/apache/airflow/blob/main/providers/amazon/src/airflow/providers/amazon/aws/hooks/redshift_sql.py#L205).
- All supported hooks
[url](https://airflow.apache.org/docs/apache-airflow-providers-openlineage/stable/supported_classes.html#sqlexecutequeryoperator)
This PR also implements a very similar logic as in [Snowflake
provider](https://github.com/apache/airflow/blob/main/providers/snowflake/src/airflow/providers/snowflake/utils/openlineage.py)
on how to deal with multiple query_ids - we are sending pair of OpenLineage
events for each query run, if there are more than one per operator run.
I've also updated the OpenLineage documentation to make it clear for the
users how the support works for operators that inherit from
SqlExecuteQueryOperator.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
