tatiana commented on code in PR #50392:
URL: https://github.com/apache/airflow/pull/50392#discussion_r2084122094
##########
devel-common/src/sphinx_exts/providers_extensions.py:
##########
@@ -314,7 +315,12 @@ def _render_openlineage_supported_classes_content():
method_names=openlineage_db_hook_methods,
class_registry=class_registry,
):
- db_type = class_name.replace("SqlApiHook", "").replace("Hook",
"")
+ db_type = ( # Extract db type from hook name
Review Comment:
Would there be an alternative / cleaner way of accomplishing this
switch/case behaviour?
Given that this PR is specific to add OpenLineage support ot the
`DatabricksSqlHook`, why are we introducing Redshif and Snowflake changes in
this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
