eladkal commented on code in PR #50454:
URL: https://github.com/apache/airflow/pull/50454#discussion_r2083499815
##########
providers/elasticsearch/src/airflow/providers/elasticsearch/hooks/elasticsearch.py:
##########
@@ -219,6 +219,14 @@ def get_uri(self) -> str:
return uri
+ def _get_polars_df(
+ self,
+ sql,
+ parameters: list | tuple | Mapping[str, Any] | None = None,
+ **kwargs,
+ ):
+ raise NotImplementedError("Polars is not supported for Elasticsearch")
Review Comment:
Do we need to have specific implementation?
The hook doesn't implement specific implementation for pandas so why would
it need one for polars?
##########
providers/elasticsearch/tests/unit/elasticsearch/hooks/test_elasticsearch.py:
##########
@@ -177,6 +177,10 @@ def test_get_df_pandas(self):
self.spy_agency.assert_spy_called(self.cur.close)
self.spy_agency.assert_spy_called(self.cur.execute)
+ def test_get_df_polars(self):
Review Comment:
I think if you parameterized the `test_get_df_pandas` to include polars that
would work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
