guan404ming commented on code in PR #50454:
URL: https://github.com/apache/airflow/pull/50454#discussion_r2083510135
##########
providers/elasticsearch/tests/unit/elasticsearch/hooks/test_elasticsearch.py:
##########
@@ -177,6 +177,10 @@ def test_get_df_pandas(self):
self.spy_agency.assert_spy_called(self.cur.close)
self.spy_agency.assert_spy_called(self.cur.execute)
+ def test_get_df_polars(self):
Review Comment:
Sure, I've updated with todo comment and this pull link hoping that would
help.
If there is more information or discussion about this integration on whether
polars or Elasticsearch official document in the future, I would go back and
try implement it.
##########
providers/elasticsearch/tests/unit/elasticsearch/hooks/test_elasticsearch.py:
##########
@@ -177,6 +177,10 @@ def test_get_df_pandas(self):
self.spy_agency.assert_spy_called(self.cur.close)
self.spy_agency.assert_spy_called(self.cur.execute)
+ def test_get_df_polars(self):
Review Comment:
Sure, I've updated with todo comment and this pull link hoping that would
help.
If there is more information or discussion about this integration on whether
polars or Elasticsearch official document in the future, I would get back here
and try implement it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
