guan404ming opened a new pull request, #50746:
URL: https://github.com/apache/airflow/pull/50746
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
## Related Issue
#50333
## Why
The log rendering would quite slow or even crash browser when rendering
large logs on the frontend
## How
By using [@tanstack/react-virtual](https://github.com/TanStack/virtual) to
support virtualized rendering, it could help reduce the pressure for rendering
with rendering partial log instead of rendering all logs at the same.
I use dynamic rendering since our log would have different height and mostly
follow this [official
example](https://tanstack.com/virtual/latest/docs/framework/react/examples/dynamic?panel=sandbox)
to implement
--> about 7x speed up (for 10000 logs on my local machine and tested 10
times)
Calculated from the moment the browser logs the fetched data to the console
until it’s finally rendered on the screen. Although this isn’t perfectly
precise, it still gives a simple metric to confirm that our speed-up trend is
positive.
before -> avg 7s
https://github.com/user-attachments/assets/520a49ba-4522-4501-bfdd-593e5d0cdb05
after -> avg 1s
https://github.com/user-attachments/assets/4dd9c48f-be7b-4112-9da2-b94b805b4829
Minor change: add `accept` field for `useLog`, which make us to support
`ndjson` easily by changing the field value and adding parse func for it after
it is fully supported.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
