guan404ming commented on code in PR #50746:
URL: https://github.com/apache/airflow/pull/50746#discussion_r2094578983
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/Logs.test.tsx:
##########
@@ -39,14 +45,16 @@ describe("Task log grouping", () => {
render(
<AppWrapper
initialEntries={["/dags/log_grouping/runs/manual__2025-02-18T12:19/tasks/generate"]}
/>,
);
+ await waitFor(() =>
expect(screen.queryByTestId("virtualized-list")).toBeInTheDocument());
+ await waitFor(() =>
expect(screen.queryByTestId("virtualized-item-0")).toBeInTheDocument());
+ fireEvent.scroll(screen.getByTestId("virtualized-list"), { target: {
scrollTop: 4050 } });
Review Comment:
This test follow the [official
test](https://github.com/TanStack/virtual/issues/641#issuecomment-2851908893)
then it works after a bunch of time of modification. But I’m still not really
clear on why it needs to be 4050 px. That value came from manual testing. One
possible explanation is that the row height in our tests doesn’t match what the
browser actually renders (20 px × 14 = 480 px).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
