Lee-W commented on code in PR #50745:
URL: https://github.com/apache/airflow/pull/50745#discussion_r2094495241
##########
airflow/migrations/versions/0093_2_2_0_taskinstance_keyed_to_dagrun.py:
##########
@@ -226,7 +226,12 @@ def upgrade():
constraints = get_mssql_table_constraints(conn,
"task_instance")
pk, _ = constraints["PRIMARY KEY"].popitem()
batch_op.drop_constraint(pk, type_="primary")
- batch_op.drop_constraint("task_instance_pkey", type_="primary")
+ elif dialect_name == "sqlite":
Review Comment:
If I'm not mistaken, I think
https://github.com/apache/airflow/blob/b2769dcb9f51fc0e4c20ec22d4e9c3340475844b/airflow/migrations/versions/0093_2_2_0_taskinstance_keyed_to_dagrun.py#L226-L228
is already doing it for MySQL, and PostgreSQL is not handled elsewhere. So in
the first commit, I removed the line
`batch_op.drop_constraint("task_instance_pkey", type_="primary")` but later
decide to let sqlite at least try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
