jscheffl commented on code in PR #50745:
URL: https://github.com/apache/airflow/pull/50745#discussion_r2094518038
##########
airflow/migrations/versions/0093_2_2_0_taskinstance_keyed_to_dagrun.py:
##########
@@ -226,7 +226,12 @@ def upgrade():
constraints = get_mssql_table_constraints(conn,
"task_instance")
pk, _ = constraints["PRIMARY KEY"].popitem()
batch_op.drop_constraint(pk, type_="primary")
- batch_op.drop_constraint("task_instance_pkey", type_="primary")
+ elif dialect_name == "sqlite":
Review Comment:
Mhm if I take a look to condition in line 225, this is ONLY mssql, not
MySQL. Attempted to read it 3 times now... but as I read the code the change
would lead to the result that in MySQL nothing is dropped. But the fix was for
sqlite. So the change should not have a side-effect on other DB engines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
