sjyangkevin commented on code in PR #50735:
URL: https://github.com/apache/airflow/pull/50735#discussion_r2096683529


##########
providers/weaviate/src/airflow/providers/weaviate/hooks/weaviate.py:
##########
@@ -190,6 +191,66 @@ def get_collection(self, name: str) -> Collection:
         client = self.conn
         return client.collections.get(name)
 
+    def delete_by_property(
+        self,

Review Comment:
   oh i see, just want to make sure I got it, I need to alter the function 
signature to below, is that right?
   
   ```python
   def delete_by_property(
       self,
       *,
       collection_names: list[str] | str,
       filter_criteria: _Filters,
       if_error: str = "stop",
       dry_run: bool = False,
       verbose: bool = False,
   ) -> list[str] | None:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to