sjyangkevin commented on code in PR #50735:
URL: https://github.com/apache/airflow/pull/50735#discussion_r2097643239
##########
providers/weaviate/src/airflow/providers/weaviate/hooks/weaviate.py:
##########
@@ -191,6 +192,70 @@ def get_collection(self, name: str) -> Collection:
client = self.conn
return client.collections.get(name)
+ def delete_by_property(
+ self,
+ *,
+ collection_names: list[str] | str,
+ filter_criteria: _Filters,
+ if_error: str = "stop",
Review Comment:
I think Literal probably is good for this case. I do see Enum can offer
benefit, but we do have other methods use the same pattern as this. To keep it
consistent, we may also refactor other methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
