gopidesupavan opened a new pull request, #51085: URL: https://github.com/apache/airflow/pull/51085
closes: #50185 Workflow trigger operations are getting locked, when using sync_to_async, to avoid that we can use async version of get_ti_count, get_dr_count, get_dagrun_state ,get_task_states. As explained in https://github.com/apache/airflow/issues/50185#issuecomment-2908470186, the issue likely causing interference with `sync_to_async` when used alongside aiologic.Lock. This is causing locks to remain unreleased, leading to blocked requests and preventing subsequent triggers from loading. Another approach, as described in https://github.com/apache/airflow/issues/50185#issuecomment-2891834967, involves fully rewriting the client and task operation methods in the triggerer to be asynchronous. While this approach is good, it introduces additional complexity, such as the need to maintain separate async versions of the client methods. I’ve already implemented an async client and some task operation methods, but I didn’t observe any significant benefits in making methods like get_ti_count, get_dr_count, get_dagrun_state, and get_task_states asynchronous. Given that, I opted for a minimal-change approach rather than building a fully async client version. After change tested with around 400+ triggers, nothing blocked everything seems working. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
